Improve return type of array_splice()
#3947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also should fix @Seldaek's example mentioned in phpstan/phpstan#11917 (comment), but the original issue was dealing with the inferred type of the passed array, so we can't close that yet. For that I have an idea ( See https://github.com/phpstan/phpstan-src/actions/runs/14536946202 |
|
also: there's a small change that test results change after merging #3946. therefore rebasing this one afterwards would be a good idea :) |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
array_splicereturns an extract, similar asarray_slice, we can make use of what we built already for the latter and get better return types with minimal effort.https://www.php.net/manual/en/function.array-splice.php
https://3v4l.org/ggnQB